Postgres Pro
Downloads
Home   >   mailing lists

Re: Binary support for pgoutput plugin - Mailing list pgsql-hackers

From Dave Cramer
Subject Re: Binary support for pgoutput plugin
Date
Msg-id CADK3HHK3Vpq=wuikKM0uCf+p9=1jPk3njw_JdmRMF+6wyp-+5Q@mail.gmail.com
Whole thread Raw
In response to Re: Binary support for pgoutput plugin  (Dave Cramer <davecramer@gmail.com>)
Responses Re: Binary support for pgoutput plugin  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
Tree view


On Mon, 6 Jul 2020 at 09:35, Dave Cramer <davecramer@gmail.com> wrote:


On Mon, 6 Jul 2020 at 09:03, Daniel Gustafsson <daniel@yesql.se> wrote:
> On 6 Jul 2020, at 14:58, Dave Cramer <davecramer@gmail.com> wrote:

> as far as rebase -i do what is advised here for squashing them. Just one patch now ?

One patch per logical change, if there are two disjoint changes in the patchset
where one builds on top of the other then multiple patches are of course fine.
My personal rule-of-thumb is to split it the way I envision it committed.

At this point it is the result of 3 rebases. I guess I'll have to break it up differently..


OK, rebased it down to 2 patches, attached.

 
Thanks,

Dave
Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Multi-byte character case-folding
Next
From: Tom Lane
Date:
Subject: Re: Multi-byte character case-folding