Re: Binary support for pgoutput plugin - Mailing list pgsql-hackers

From Dave Cramer
Subject Re: Binary support for pgoutput plugin
Date
Msg-id CADK3HHJk2+2xTfT5MkeJuHz6DGnrrtAKmAEEfHX-ePB3X5-NzQ@mail.gmail.com
Whole thread Raw
In response to Re: Binary support for pgoutput plugin  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Binary support for pgoutput plugin  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers


On Tue, 14 Jul 2020 at 09:26, Daniel Gustafsson <daniel@yesql.se> wrote:
> On 13 Jul 2020, at 15:11, Dave Cramer <davecramer@gmail.com> wrote:

I took another look at the updated version today.  Since there now were some
unused variables and (I believe) unnecessary checks (int size and endianness
etc) left, I took the liberty to fix those.  I also fixed some markup in the
catalog docs, did some minor tidying up and ran pgindent on it.

The attached is a squash of the 4 patches in your email with the above fixes.
I'm again marking it RfC since I believe all concerns raised so far has been
addressed.

> Added the test case that Daniel had created.

Nope, still missing AFAICT =) But I've included it in the attached.


Thanks!

Dave


pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Improvements in Copy From
Next
From: "David G. Johnston"
Date:
Subject: Re: DROP relation IF EXISTS Docs and Tests - Bug Fix