Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display - Mailing list pgadmin-hackers

From Dave Cramer
Subject Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display
Date
Msg-id CADK3HHJLedC=bOnQwkSnU3D9GNS4Suqd-1zevd-PuNCqm=bSmw@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display  (Violet Cheng <vcheng@pivotal.io>)
Responses Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display  (Jing Li <jingli@pivotal.io>)
List pgadmin-hackers
Tree view
Hi Violet.

I don't really like the way this has been implemented. It adds a variable which is only used for gpdb.

There are other places in the code where the behaviour is changed if the server is ppas or regular postgres. 

Candidly I think all of this needs restructuring.

Dave Cramer

On 15 August 2017 at 23:29, Violet Cheng <vcheng@pivotal.io> wrote:
Hi,

Any comment on this patch? If no, will it be committed soon?

Thanks,
Violet

On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
Hi Hackers!

This patch enables Greenplum users to see the same charts on the dashboard as postgres users. It also adds some additional information to the DDL that is Greenplum specific and necessary to create a new table.

Thanks!
Sarah




pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: pgAdmin4: Random failure of FTS test cases due to improper randomstring creation
Next
From: Thomas Krennwallner
Date:
Subject: PATCH: pgagent connection string parsing