Re: psql \dh: List High-Level (Root) Tables and Indexes - Mailing list pgsql-hackers

From Sadeq Dousti
Subject Re: psql \dh: List High-Level (Root) Tables and Indexes
Date
Msg-id CADE6LvirX0iDrSPoBqT-UCmjoBmJJRPva40YxAx34xgPODkuMg@mail.gmail.com
Whole thread Raw
In response to Re: psql \dh: List High-Level (Root) Tables and Indexes  (Greg Sabino Mullane <htamfids@gmail.com>)
List pgsql-hackers
Dear Greg,

Thank you so much for the kind and prompt review!

Please find the patches attached. The second patch (0002) is where I applied the requested changes.

Best regards,
Sadeq Dousti


On Wed, Feb 26, 2025 at 1:01 AM Greg Sabino Mullane <htamfids@gmail.com> wrote:
The patch applies cleanly, and works as advertised. Nice work!

Quick notes:

* doc/src/sgml/ref/psql-ref.sgml

In the varlistentry section, the order should be the same as the other places (N after m)

Line 1644 has an extra comma

Line 1651, maybe the example is simpler as \dNt to keep the wording better, because "indexes that are not partitions" looks odd.

These bits:

  pg_log_error("Did not find any%s relations named \"%s\".",
    no_partition_description, pattern);

are not good for translation. We want things simple with replaceable args/constants, but not replaceable words.

I think the myopt.title ones are fine.

* bin/psql/help.c:

\\dN[Sx+] [PATTERN]     list relation, table, index (no partitions)

better as:

\\dN[Sx+] [PATTERN]     list tables and indexes (no partitions)

Cheers,
Greg

--
Enterprise Postgres Software Products & Tech Support

Attachment

pgsql-hackers by date:

Previous
From: "Devulapalli, Raghuveer"
Date:
Subject: RE: Improve CRC32C performance on SSE4.2
Next
From: Masahiko Sawada
Date:
Subject: Re: Parallel heap vacuum