Re: [HACKERS] [PATCH] Push limit to sort through a subquery - Mailing list pgsql-hackers

From Douglas Doole
Subject Re: [HACKERS] [PATCH] Push limit to sort through a subquery
Date
Msg-id CADE5jY+BOPdtzR1H0GtNqE2hf3D-eCEiS6_-esmVt4XtZf-kDg@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] [PATCH] Push limit to sort through a subquery  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [HACKERS] [PATCH] Push limit to sort through a subquery  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
1. The header comment for pass_down_bound() could mention "one or more
levels of subqueries" rather than "a subquery".

Fixed 

2. The first of the comments in the function body appears to have a
whitespace issue that needs to be fixed manually or, better yet,
addressed by pgindent.

Fixed
 
3. The formatting of the comment in the regression tests appears to be
unlike any other comment in that same file.

A side effect of inheriting it from our branches ;-) Reworked.
 
4. I am pretty doubtful that "Memory: 25kB" is going to be stable
enough for us to want that output memorialized in the regression ...

Fair enough. I wanted to be a bit more sophisticated in my check than looking for a single value so I worked out something that distills the explain down to the key elements.
Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] expanding inheritance in partition bound order
Next
From: Pavel Stehule
Date:
Subject: Re: [HACKERS] possible encoding issues with libxml2 functions