Re: [HACKERS] make async slave to wait for lsn to be replayed - Mailing list pgsql-hackers

From Kevin Hale Boyes
Subject Re: [HACKERS] make async slave to wait for lsn to be replayed
Date
Msg-id CADAecHWKpaPuPGXAMOH=wmhTpydHWGPOk9KWX97UYhp5GdqCWw@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] make async slave to wait for lsn to be replayed  (Alexander Korotkov <aekorotkov@gmail.com>)
Responses Re: [HACKERS] make async slave to wait for lsn to be replayed
List pgsql-hackers
I noticed the commit and had a question and a comment.
There is a small problem in func.sgml in the sentence "After that the changes made of primary".  Should be "on primary".

In the for loop in WaitForLSNReplay, shouldn't the check for in-recovery be moved up above the call to GetXLogReplayRecPtr?
If we get promoted while waiting for the timeout we could call GetXLogReplayRecPtr while not in recovery.

Thanks,
Kevin.

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Why is citext/regress failing on hamerkop?
Next
From: Alexander Korotkov
Date:
Subject: Re: [HACKERS] make async slave to wait for lsn to be replayed