On Tue, Oct 29, 2024 at 9:48 AM Michael Paquier <michael@paquier.xyz> wrote:
On Mon, Oct 28, 2024 at 03:00:12PM -0400, Andrew Dunstan wrote: > Well, it seems like it's clearly a bug. I'm never happy leaving bugs > unfixed. As for 12, what's the point of putting out one last release if it's > not to fix bugs?
There is always a risk of breaking something that worked previously, and we would be out of options to address these once the branch is EOL'd. The risk/reward ratio for v12 is really different, so I'd advise some caution particularly with this area of the code.
> EDB's customer will probably be happy if we just fix 15, but I would rather > take a broader view and fix it for other possible users too. > > I'm traveling for a few days but it was my intention to work on these when I > am back.
I didn't push the fixes for release 12, like you requested, but I pushed the rest.
Unfortunately for various reasons I don't currently have a Windows test instance, but these were previously tested by Alexandra and me so I'm pretty confident they will be ok.
When I get my hands on a Windows machine again I will work on adding some Windows tests for pg_reqind with tablespaces.
