Re: WIP Incremental JSON Parser - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: WIP Incremental JSON Parser
Date
Msg-id CAD5tBc+DRt9ArFC7CmG0xpmk6i8xbn5a6Hq1i-21VP8-yiQO_g@mail.gmail.com
Whole thread Raw
In response to Re: WIP Incremental JSON Parser  (Jacob Champion <jacob.champion@enterprisedb.com>)
Responses Re: WIP Incremental JSON Parser
List pgsql-hackers


On Mon, Mar 25, 2024 at 7:12 PM Jacob Champion <jacob.champion@enterprisedb.com> wrote:
On Mon, Mar 25, 2024 at 4:02 PM Andrew Dunstan <andrew@dunslane.net> wrote:
> Well, what's the alternative? The current parser doesn't check stack depth in frontend code. Presumably it too will eventually just run out of memory, possibly rather sooner as the stack frames could  be more expensive than the incremental parser stack extensions.

Stack size should be pretty limited, at least on the platforms I'm
familiar with. So yeah, the recursive descent will segfault pretty
quickly, but it won't repalloc() an unbounded amount of heap space.
The alternative would just be to go back to a hardcoded limit in the
short term, I think.



OK, so we invent a new error code and have the parser  return that if the stack depth gets too big?

cheers

andrew

 

pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: WIP Incremental JSON Parser
Next
From: Jacob Champion
Date:
Subject: Re: WIP Incremental JSON Parser