Re: [HACKERS] [PATCH] pageinspect function to decode infomasks - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: [HACKERS] [PATCH] pageinspect function to decode infomasks
Date
Msg-id CAD21AoDqvHbjSO-2GNJ00-nR6hTTNvD_1P8n7dOrF8_vhQW0sA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] [PATCH] pageinspect function to decode infomasks  (Craig Ringer <craig@2ndquadrant.com>)
List pgsql-hackers
On Thu, Sep 14, 2017 at 11:00 PM, Craig Ringer <craig@2ndquadrant.com> wrote:
> On 14 September 2017 at 19:57, Ashutosh Sharma <ashu.coek88@gmail.com>
> wrote:
>
>>
>>
>> Are you planning to work on the review comments from Robert, Moon
>> Insung and supply the new patch. I just had a quick glance into this
>> mail thread (after a long time) and could understand Robert's concern
>> till some extent. I think, he is trying to say that if a tuple is
>> frozen (committed|invalid) then it shouldn't be shown as COMMITTED and
>> INVALID together in fact it should just be displayed as FROZEN tuple.
>
>
> Yes, I'd like to, and should have time for it in this CF.
>
> My plan is to emit raw flags by default, so FROZEN would't be shown at all,
> only COMMITTED|INVALID. If the bool to decode combined flags is set, then
> it'll show things like FROZEN, and hide COMMITTED|INVALID. Similar for other
> combos.
>

FWIW, I agree with this direction. ISTM the showing the raw flags by
default and having an option to show combined flags would be a right
way.
I sometimes wanted to have the same mechanism for lp_flags but maybe
it should be discussed on a separated thread.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: [HACKERS] SIGSEGV in BRIN autosummarize
Next
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] SIGSEGV in BRIN autosummarize