Re: Introduce wait_for_subscription_sync for TAP tests - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: Introduce wait_for_subscription_sync for TAP tests
Date
Msg-id CAD21AoDD4-6PJHp=X-bo7DgRjJsU92LVvL7qotCf0oO+QjsNAQ@mail.gmail.com
Whole thread Raw
In response to Re: Introduce wait_for_subscription_sync for TAP tests  (Amit Kapila <amit.kapila16@gmail.com>)
Responses RE: Introduce wait_for_subscription_sync for TAP tests
Re: Introduce wait_for_subscription_sync for TAP tests
List pgsql-hackers
On Thu, Aug 4, 2022 at 10:37 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Wed, Aug 3, 2022 at 10:21 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > Pushed this one and now I'll look at your other patch.
> >
>
> I have pushed the second patch as well after making minor changes in
> the comments. Alvaro [1] and Tom [2] suggest to back-patch this and
> they sound reasonable to me. Will you be able to produce back branch
> patches?

Yes. I've attached patches for backbranches. The updates are
straightforward on v11 - v15. However, on v10, we don't use
wait_for_catchup() in some logical replication test cases. The commit
bbd3363e128dae refactored the tests to use wait_for_catchup but it's
not backpatched. So in the patch for v10, I didn't change the code
that was changed by the commit. Also, since wait_for_catchup requires
to specify $target_lsn, unlike the one in v11 or later, I changed
wait_for_subscription_sync() accordingly.

Regards,

--
Masahiko Sawada
EDB:  https://www.enterprisedb.com/

Attachment

pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: Race between KeepFileRestoredFromArchive() and restartpoint
Next
From: Bharath Rupireddy
Date:
Subject: Re: pg_receivewal fail to streams when the partial file to write is not fully initialized present in the wal receiver directory