Re: meson: catalog/syscache_ids.h isn't installed - Mailing list pgsql-hackers

On Mon, Feb 5, 2024 at 10:29 AM Sutou Kouhei <kou@clear-code.com> wrote:
>
> Hi,
>
> catalog/syscache_ids.h is referred by utils/syscache.h but
> it's not installed with Meson.
>
> FYI:
> * 9b1a6f50b91dca6610932650c8c81a3c924259f9
>   It uses catalog/syscache_ids.h in utils/syscache.h but
>   catalog/syscache_ids.h isn't installed.
> * 6eb6086faa3842c2a38a1ee2f97bf9a42ce27610
>   It changes a Makefile to install catalog/syscache_ids.h but
>   it doesn't change meson.build.
>
> ----
> diff --git a/src/include/catalog/meson.build b/src/include/catalog/meson.build
> index 6be76dca1d..0bf6e112d5 100644
> --- a/src/include/catalog/meson.build
> +++ b/src/include/catalog/meson.build
> @@ -114,7 +114,7 @@ output_install = [
>    dir_data,
>    dir_data,
>    dir_include_server / 'catalog',
> -  false,
> +  dir_include_server / 'catalog',
>    dir_include_server / 'catalog',
>    dir_include_server / 'catalog',
>  ]
> ----
>

Thank you for reporting the issue and the patch.

I've confirmed this patch fixes the issue. But I don't have enough
knowledge of meson to assess this fix.

Peter, could you check this fix as it seems the recent commits forgot
to update the meson.build file?

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com