Re: suspicious valgrind reports about radixtree/tidstore on arm64 - Mailing list pgsql-hackers

On Thu, Jun 20, 2024 at 4:58 PM John Naylor <johncnaylorls@gmail.com> wrote:
>
> On Thu, Jun 20, 2024 at 8:12 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> > On Thu, Jun 20, 2024 at 7:54 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > >
> > > I don't know if there's any reason why the current order
> > > is preferable.)
> >
> > IIUC there is no particular reason for the current order in RT_NODE_48.
>
> Yeah. I found that simply swapping them enables clang to avoid
> double-initialization, but gcc still can't figure it out and must be
> told to stop at slot_idxs[]. I'd prefer to do it that way and document
> that slot_idxs is purposefully the last member of the fixed part of
> the struct.

+1

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com