Re: Reviewing freeze map code - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: Reviewing freeze map code
Date
Msg-id CAD21AoCQGTKDxQ6YfrJ0+=ev6A3i3pt2ULdWxCtwPLKR2E77jg@mail.gmail.com
Whole thread Raw
In response to Reviewing freeze map code  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Tue, May 3, 2016 at 6:48 AM, Andres Freund <andres@anarazel.de> wrote:
> fd31cd2 Don't vacuum all-frozen pages.

-                       appendStringInfo(&buf, _("pages: %u removed,
%u remain, %u skipped due to pins\n"),
+                       appendStringInfo(&buf, _("pages: %u removed,
%u remain, %u skipped due to pins, %u skipped frozen\n"),

vacrelstats->pages_removed,
                                                         vacrelstats->rel_pages,
-
vacrelstats->pinskipped_pages);
+
vacrelstats->pinskipped_pages,
+
vacrelstats->frozenskipped_pages);

The verbose information about skipping frozen page is emitted by only
autovacuum.
But I think that this information is also helpful for manual vacuum.

Please find attached patch which fixes that.

Regards,

--
Masahiko Sawada

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [COMMITTERS] pgsql: Add TAP tests for pg_dump
Next
From: Simon Riggs
Date:
Subject: Re: pg9.6 segfault using simple query (related to use fk for join estimates)