On Fri, Sep 11, 2015 at 10:15 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Fri, Sep 11, 2015 at 3:41 AM, Beena Emerson <memissemerson@gmail.com> wrote:
>> Please find attached the WIP patch for the proposed feature. It is built
>> based on the already discussed design.
>>
>> Changes made:
>> - add new parameter "sync_file" to provide the location of the pg_syncinfo
>> file. The default is 'ConfigDir/pg_syncinfo.conf', same as for pg_hba and
>> pg_ident file.
>
> I am not sure that's really necessary. We could just hardcode its location.
>
>> - pg_syncinfo file will hold the sync rep information in the approved JSON
>> format.
>
> OK. Have you considered as well the approach to add support for
> multi-line GUC parameters? This has been mentioned a couple of time
> above as well, with something like that I imagine:
> param = 'value1,' \
> 'value2,' \
> 'value3'
> and this reads as 'value1,value2,value3'. This would benefit as well
> for other parameters.
>
I agree with adding support for multi-line GUC parameters.
But I though it is:
param = 'param1,
param2,
param3'
This reads as 'value1,value2,value3'.
Regards,
--
Masahiko Sawada
