Re: Is Recovery actually paused? - Mailing list pgsql-hackers

On Sat, Jan 16, 2021 at 12:28 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> ---
> +       /* test for recovery pause if user has requested the pause */
> +       if (((volatile XLogCtlData *) XLogCtl)->recoveryPause)
> +           recoveryPausesHere(false);
> +
> +       now = GetCurrentTimestamp();
> +
>
> Hmm, if the recovery pauses here, the wal receiver isn't launched even
> when wal_retrieve_retry_interval has passed, which seems not good. I
> think we want the recovery to be paused but want the wal receiver to
> continue receiving WAL.

I had misunderstood the code and the patch, please ignore this
comment. Pausing the recovery here is fine with me.

Regards,

-- 
Masahiko Sawada
EnterpriseDB:  https://www.enterprisedb.com/