Postgres Pro
Downloads
Home   >   mailing lists

Re: Make pg_waldump report replication origin ID, LSN, and timestamp. - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: Make pg_waldump report replication origin ID, LSN, and timestamp.
Date
Msg-id CAD21AoB+k6F-P4f_Jho0zwZHeNt6hcp0Xzw4-zkGO5opN-mTjA@mail.gmail.com
Whole thread Raw
In response to Re: Make pg_waldump report replication origin ID, LSN, and timestamp.  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Make pg_waldump report replication origin ID, LSN, and timestamp.  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
On Wed, Dec 8, 2021 at 4:31 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Mon, Dec 06, 2021 at 11:24:09PM +0900, Masahiko Sawada wrote:
> > On Mon, Dec 6, 2021 at 5:09 PM Michael Paquier <michael@paquier.xyz> wrote:
> >> Shouldn't you check for parsed.origin_lsn instead?  The replication
> >> origin is stored there as far as I read EndPrepare().
> >
> > Also, looking at PrepareRedoAdd(), we check the replication origin id.
> > So I think that it'd be better to check origin_id for consistency.
>
> Okay, this consistency would make sense, then.  Perhaps some comments
> should be added to tell that?

Agreed. I've attached an updated patch that incorporated your review
comments. Please review it.

Regards,

-- 
Masahiko Sawada
EDB:  https://www.enterprisedb.com/
Attachment

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Is it correct to update db state in control file as "shutting down" during end-of-recovery checkpoint?
Next
From: Michael Paquier
Date:
Subject: Re: enable certain TAP tests for MSVC builds