Re: Fix showing XID of a spectoken lock in an incorrect field of pg_locks view. - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: Fix showing XID of a spectoken lock in an incorrect field of pg_locks view.
Date
Msg-id CAD21AoAx8FT0aghtKYUioLjBr4kzfxNYXHT2pTZ8V2zmkjzvpg@mail.gmail.com
Whole thread Raw
In response to Re: Fix showing XID of a spectoken lock in an incorrect field of pg_locks view.  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Fri, Jan 6, 2023 at 9:00 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Thu, Jan 5, 2023 at 11:46 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >
> > Agreed. Attached the updated patch.
> >
>
> Thanks, the patch looks good to me. I think it would be probably good
> to backpatch this but it has the potential to break some monitoring
> scripts which were using the wrong columns for transaction id and spec
> token number.

Right.

> As this is not a very critical issue and is not reported
> till now, so it may be better to leave backpatching it. What do you
> think?

Considering the compatibility, I'm inclined to agree not to backpatch
it. If someone complains about the current behavior in back branches
in the future, we can backpatch it.

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Dean Rasheed
Date:
Subject: Re: [PATCH] psql: Add tab-complete for optional view parameters
Next
From: Pavel Borisov
Date:
Subject: Re: POC: Lock updated tuples in tuple_update() and tuple_delete()