Re: The number of character limitation of custom script on pgbench - Mailing list pgsql-hackers

From Sawada Masahiko
Subject Re: The number of character limitation of custom script on pgbench
Date
Msg-id CAD21AoAVr4P++=RXuZoJiHr8FX_3AQKteMjD5d79YKB++JWjdA@mail.gmail.com
Whole thread Raw
In response to Re: The number of character limitation of custom script on pgbench  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: The number of character limitation of custom script on pgbench  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, Nov 13, 2013 at 10:27 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
>> On 11/13/13, 6:18 AM, Sawada Masahiko wrote:
>>> The function of custom script of pgbench allows only  BUFSIZ
>>> (i.g.,1024byte) or less as length of a SQL.
>>> So I'm thinking following solution.
>>> (1) to increase buffer size
>>> (2) to change to variable buffer size
>>> (3) to return ERROR with information
>
>> I'd go for #2.  But at least an error.
>
> #2 definitely.  I've run into this limitation myself recently, and
> so have other people.  It's time to fix it.
>

I attached the patch which solves this problem, and have submitted to CF3.
I changed how to get the SQL from custom script file.

Regards,

-------
Sawada Masahiko

Attachment

pgsql-hackers by date:

Previous
From: Haribabu kommi
Date:
Subject: Re: New option for pg_basebackup, to specify a different directory for pg_xlog
Next
From: Simon Riggs
Date:
Subject: Re: Proof of concept: standalone backend with full FE/BE protocol