On Sun, Apr 3, 2022 at 9:45 AM Noah Misch <noah@leadboat.com> wrote:
>
> On Sat, Apr 02, 2022 at 08:44:45PM +0900, Masahiko Sawada wrote:
> > On Sat, Apr 2, 2022 at 7:04 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > > On Sat, Apr 2, 2022 at 1:43 PM Noah Misch <noah@leadboat.com> wrote:
> > > > Some options:
> > > > - Move subskiplsn after subdbid, so it's always aligned anyway. I've
> > > > confirmed that this lets the test pass, in 44s.
> > > > - Move subskiplsn to the CATALOG_VARLEN section, despite its fixed length.
> > >
> > > +1 to any one of the above. I mildly prefer the first option as that
> > > will allow us to access the value directly instead of going via
> > > SysCacheGetAttr but I am fine either way.
> >
> > +1. I also prefer the first option.
>
> Sounds good to me.
I've attached the patch for the first option.
> - Introduce a new typalign value suitable for uint64. This is more intrusive,
> but it's more future-proof. Looking beyond catalog columns, it might
> improve performance by avoiding unaligned reads.
The third option would be a good item for PG16 or later.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
