Re: [PATCH] postgres_fdw extension support - Mailing list pgsql-hackers

From Paul Ramsey
Subject Re: [PATCH] postgres_fdw extension support
Date
Msg-id CACowWR1wiEbbtY54wV4gnzNQi+BXB=Y8A7RiveFLAbzeaOrFJQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] postgres_fdw extension support  (Paul Ramsey <pramsey@cleverelephant.ca>)
Responses Re: [PATCH] postgres_fdw extension support
List pgsql-hackers
Here's a third revision that allows the 'extensions' option on the
wrapper as well, so that supported extensions can be declared once in
one place.

Since the "CREATE FOREIGN DATA WRAPPER" statement is actually called
inside the "CREATE EXTENSION" script for postgres_fdw, the way to get
this option is actually to alter the wrapper,

  ALTER FOREIGN DATA WRAPPER postgres_fdw OPTIONS ( extensions 'seg' );

Right now declaring extensions at different levels is additive, I
didn't add the option to revoke an extension for a particular server
definition (the "cube,-postgis" entry for example). If that's a
deal-breaker, I can add it too, but it felt like something that could
wait for a user to positively declare "I must have that feature!"

P.


On Fri, Jul 17, 2015 at 5:58 AM, Paul Ramsey <pramsey@cleverelephant.ca> wrote:
>
> On July 17, 2015 at 5:57:42 AM, Simon Riggs (simon@2ndquadrant.com(mailto:simon@2ndquadrant.com)) wrote:
>
>> Options already exist on CREATE FOREIGN DATA WRAPPER, so it should be easy to support that.
>>
>> I'd rather add it once on the wrapper than be forced to list all the options on every foreign server, unless
requiredto do so. 
>
> Gotcha, that does make sense.
>
> P.

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pgbench stats per script & other stuff
Next
From: Fabien COELHO
Date:
Subject: Re: pgbench stats per script & other stuff