Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] introduce XLogLockBlockRangeForCleanup() - Mailing list pgsql-hackers

From Amit Khandekar
Subject Re: [PATCH] introduce XLogLockBlockRangeForCleanup()
Date
Msg-id CACoZds2nbjNUBBJ4vo0fepS+NVBAhYLfK5NZNiUa3PBr2-bmWQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] introduce XLogLockBlockRangeForCleanup()  (Abhijit Menon-Sen <ams@2ndQuadrant.com>)
Responses Re: [PATCH] introduce XLogLockBlockRangeForCleanup()  (Abhijit Menon-Sen <ams@2ndQuadrant.com>)
List pgsql-hackers
Tree view



On 4 July 2014 19:11, Abhijit Menon-Sen <ams@2ndquadrant.com> wrote:
Updated patch attached, thanks.

Amit: what's your conclusion from the review?

Other than some minor comments as mentioned below, I don't have any more issues, it looks all good.

XLogLockBlockRangeForCleanup() function header comments has the function name spelled: XLogBlockRangeForCleanup

In GetBufferWithoutRelcache(), we can call BufferDescriptorGetBuffer(buf) rather than BufferDescriptorGetBuffer(&BufferDescriptors[buf_id]).



-- Abhijit

pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls
Next
From: Abhijit Menon-Sen
Date:
Subject: Re: [PATCH] introduce XLogLockBlockRangeForCleanup()