Postgres Pro
Downloads
Home   >   mailing lists

Re: [COMMITTERS] pgsql: Modify BufferGetPage() to prepare for "snapshot too old" feature - Mailing list pgsql-hackers

From Kevin Grittner
Subject Re: [COMMITTERS] pgsql: Modify BufferGetPage() to prepare for "snapshot too old" feature
Date
Msg-id CACjxUsPOm-cGPdG7_XpPQ_jLPhz7dqqphuOO5aqsvZ6iM4qdQQ@mail.gmail.com
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Modify BufferGetPage() to prepare for "snapshot too old" feature  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: [COMMITTERS] pgsql: Modify BufferGetPage() to prepare for "snapshot too old" feature  (Kevin Grittner <kgrittn@gmail.com>)
List pgsql-hackers
Tree view 
On Wed, Aug 24, 2016 at 12:40 PM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
> Kevin Grittner wrote:
>> Modify BufferGetPage() to prepare for "snapshot too old" feature
>
> I just noticed that this commit added a line to #include catalog/catalog.h
> in storage/bufmgr.h.  I can't find any reason for it doing so, and I
> think it's a bad line to have there.  Can we get it removed?

Will do that now.  It was initially added because
IsCatalogRelation() was referenced in storage/bufmgr.h, but for
various reasons it seemed better to move that, and I missed the
include.  Thanks for spotting it.

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Artur Zakirov
Date:
Subject: Re: Bug in to_timestamp().
Next
From: Alvaro Herrera
Date:
Subject: Re: Write Ahead Logging for Hash Indexes