> This triggers tuples_equal to fail. To fix that, I improved the tuples_equal > such that it skips the dropped columns. >
By any chance, have you tried with generated columns?
Yes, it shows the same behavior.
See logicalrep_write_tuple()/logicalrep_write_attrs() where we neither send anything for dropped columns nor for generated columns.
Similarly, on receiving side, in logicalrep_rel_open() and slot_store_data(), we seem to be using NULL for such columns.
Thanks for the explanation, it helps a lot.
Yes, it would be better to report and discuss this in a separate thread,
Done via [1]
> Attached as v40_0001 on the patch. > > Note that I need to have that commit as 0001 so that 0002 patch > passes the tests. >
I think we can add such a test (which relies on existing buggy behavior) later after fixing the existing bug. For now, it would be better to remove that test and add it after we fix dropped columns issue in HEAD.
Alright, when I push the next version (hopefully tomorrow), I'll follow this suggestion.
