Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher - Mailing list pgsql-hackers

From Önder Kalacı
Subject Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
Date
Msg-id CACawEhWd-BSpcGHKPjt3zVsGaRwP2+XuJoPPCDaGHM6XL8AqYg@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher  (Önder Kalacı <onderkalaci@gmail.com>)
Responses Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Tree view
Hi Amit, all


I'll look for more opportunities and reply to the thread. I wanted to send
this mail so that you can have a look at (1) earlier.


I merged SUBSCRIPTION CREATE/DROP INDEX WORKS WITHOUT ISSUES
into SUBSCRIPTION CAN USE INDEXES WITH EXPRESSIONS AND COLUMNS.

Also, merged SUBSCRIPTION USES INDEX WITH PUB/SUB DIFFERENT DATA and
 A UNIQUE INDEX THAT IS NOT PRIMARY KEY OR REPLICA IDENTITY

So, we have 6 test cases left. I start to feel that trying to merge further is going to start making
the readability get worse. Do you have any further easy test case merge suggestions?

I think one option could be to drop some cases altogether, but not sure we'd want that.

As a semi-related question: Are you aware of any setting that'd make pg_stat_all_indexes
reflect the changes sooner? It is hard to debug what is the bottleneck in the tests, but
I have a suspicion that there might be several poll_query_until() calls on 
pg_stat_all_indexes, which might be the reason?

Attaching v43. 
Attachment

pgsql-hackers by date:

Previous
From: Jim Jones
Date:
Subject: Re: [PATCH] Add pretty-printed XML output option
Next
From: Masahiko Sawada
Date:
Subject: Re: [PoC] Improve dead tuple storage for lazy vacuum