Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher - Mailing list pgsql-hackers

From Önder Kalacı
Subject Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
Date
Msg-id CACawEhVFScb4uTi-b3vXb=0o6nQMJ8emLYG2LaLUH43gC2c0yw@mail.gmail.com
Whole thread Raw
In response to RE: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher  ("osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>)
List pgsql-hackers
Tree view
Hi,
 

FYI, I noticed that v5 causes cfbot failure in [1].
Could you please fix it in the next version ?

Thanks for letting me know!



[19:44:38.420] execReplication.c: In function ‘RelationFindReplTupleByIndex’:
[19:44:38.420] execReplication.c:186:24: error: ‘eq’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
[19:44:38.420]   186 |   if (!indisunique && !tuples_equal(outslot, searchslot, eq))
[19:44:38.420]       |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[19:44:38.420] cc1: all warnings being treated as errors


It is kind of interesting that the compiler cannot understand that `eq` is only used when !indisunique. Anyway, now I've sent v6 where I avoid the warning with a slight refactor to avoid the compile warning.

Thanks,
Onder KALACI  

  
Attachment

pgsql-hackers by date:

Previous
From: Zhang Mingli
Date:
Subject: [patch]HashJoin crash
Next
From: Peter Eisentraut
Date:
Subject: Re: tests and meson - test names and file locations