Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher - Mailing list pgsql-hackers

From Önder Kalacı
Subject Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
Date
Msg-id CACawEhV68Ry7BGJV150xsUskJPa88rpOf3zo_OcA_MpSWGQobQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher  (Andres Freund <andres@anarazel.de>)
Responses Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view
Hi, 

Thanks for the heads-up.


Needs another rebase, I think:

https://cirrus-ci.com/task/5592444637544448

[05:44:22.102] FAILED: src/backend/postgres_lib.a.p/replication_logical_worker.c.o
[05:44:22.102] ccache cc -Isrc/backend/postgres_lib.a.p -Isrc/include -I../src/include -Isrc/include/storage -Isrc/include/utils -Isrc/include/catalog -Isrc/include/nodes -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -g -fno-strict-aliasing -fwrapv -fexcess-precision=standard -D_GNU_SOURCE -Wmissing-prototypes -Wpointer-arith -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -Wdeclaration-after-statement -Wno-format-truncation -Wno-stringop-truncation -fPIC -pthread -DBUILDING_DLL -MD -MQ src/backend/postgres_lib.a.p/replication_logical_worker.c.o -MF src/backend/postgres_lib.a.p/replication_logical_worker.c.o.d -o src/backend/postgres_lib.a.p/replication_logical_worker.c.o -c ../src/backend/replication/logical/worker.c
[05:44:22.102] ../src/backend/replication/logical/worker.c: In function ‘get_usable_indexoid’:
[05:44:22.102] ../src/backend/replication/logical/worker.c:2101:36: error: ‘ResultRelInfo’ has no member named ‘ri_RootToPartitionMap’
[05:44:22.102]  2101 |   TupleConversionMap *map = relinfo->ri_RootToPartitionMap;
[05:44:22.102]       |                                    ^~


Yes, it seems the commit (fb958b5da86da69651f6fb9f540c2cfb1346cdc5) broke the build and commit(a61b1f74823c9c4f79c95226a461f1e7a367764b) broke the tests. But the fixes were trivial. All tests pass again.  

Attached v22.

Onder KALACI
Attachment

pgsql-hackers by date:

Previous
From: Мельников Игорь
Date:
Subject: Re: Add PL/pgSQL extra check no_data_found
Next
From: Niyas Sait
Date:
Subject: Re: [PATCH] Add native windows on arm64 support