Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher - Mailing list pgsql-hackers

From Önder Kalacı
Subject Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
Date
Msg-id CACawEhV0ZOJJSWOdmNd0Oh3Z4KQc90hfn8eX3R+_CHt-2aVi-g@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher  (vignesh C <vignesh21@gmail.com>)
List pgsql-hackers
Tree view

Amit Kapila <amit.kapila16@gmail.com>, 14 Mar 2023 Sal, 11:59 tarihinde şunu yazdı:
On Tue, Mar 14, 2023 at 12:48 PM Önder Kalacı <onderkalaci@gmail.com> wrote:
>>
>> 2.
>> +# make sure that the subscriber has the correct data after the update UPDATE
>>
>> "update UPDATE" seems to be a typo.
>>
>
> thanks, fixed
>
>>
>> 3.
>> +# now, drop the index with the expression, and re-create index on column lastname
>>
>> The comment says "re-create index on column lastname" but it seems we didn't do
>> that, should it be modified to something like:
>> # now, drop the index with the expression, we will use sequential scan
>>
>>
>
> Thanks, fixed
>
> I'll add the changes to v49 in the next e-mail.
>

It seems you forgot to address these last two comments in the latest version.


Oops, sorry. I think when I get your test changes, I somehow overridden these changes
on my local.
Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
Next
From: vignesh C
Date:
Subject: Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher