Re: [BUGS] [HACKERS] Segmentation fault in libpq - Mailing list pgsql-hackers

From Michal Novotný
Subject Re: [BUGS] [HACKERS] Segmentation fault in libpq
Date
Msg-id CACSGxCNfmqBXKoK6MqZvofsrcX0ZpTc-Cx+mCZWxhHL=RzZabw@mail.gmail.com
Whole thread Raw
In response to Re: [BUGS] [HACKERS] Segmentation fault in libpq  (Merlin Moncure <mmoncure@gmail.com>)
List pgsql-hackers
Hi all,
thank you all for your advice. I've been investigating this a little more and finally it turned out it's not a bug in libpq although I got confused by going deep as several libpq functions. The bug was really on our side after trying to use connection pointer after calling PQfinish(). The code is pretty complex so it took some time to investigate however I would like to apologize for "blaming" libpq instead of our code.

Anyway, thank you all for valuable advice.
Have a great time,
Michal

2017-06-29 16:30 GMT+02:00 Merlin Moncure <mmoncure@gmail.com>:
On Thu, Jun 29, 2017 at 9:12 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Merlin Moncure <mmoncure@gmail.com> writes:
>> On Thu, Jun 29, 2017 at 8:23 AM, Michal Novotny
>> <michal.novotny@greycortex.com> wrote:
>>> Could you please help me based on information provided above?
>
>> You might want to run your code through some analysis tools (for
>> example, valgrind).
>
> valgrind is not a perfect tool for finding that kind of problem,
> especially if you can't reproduce the crash reliably; but at least
> valgrind is readily available and easy to use, so you might as
> well start there and see if it finds anything.  If you have access
> to any sort of static analysis tool (eg, Coverity), that might be
> more likely to help.  Or you could fall back on manual code
> auditing, if the program isn't very big.

clang static analyzer is another good tool to check out

https://clang-analyzer.llvm.org/

merlin



--
Michal Novotny
System Development Lead
GREYCORTEX s.r.o.
Purkynova 127, 61200 Brno
Czech Republic

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Race-like failure in recovery/t/009_twophase.pl
Next
From: Andres Freund
Date:
Subject: Re: [BUGS] [HACKERS] Segmentation fault in libpq