Heikki Linnakangas <hlinnaka@iki.fi> writes:
> On 23/02/2023 13:20, Peter Eisentraut wrote:
>> If you don't have \timing turned on before the query starts, psql won't
>> record what the time was before the query, so you can't compute the run
>> time afterwards. This kind of feature would only work if you always
>> take the start time, even if \timing is turned off.
> Correct. That seems acceptable though? gettimeofday() can be slow on
> some platforms, but I doubt it's *that* slow, that we couldn't call it
> two times per query.
Yeah, you'd need to capture both the start and stop times even if
\timing isn't on, in case you get asked later. But the backend is
going to call gettimeofday at least once per query, likely more
depending on what features you use. And there are inherently
multiple kernel calls involved in sending a query and receiving
a response. I tend to agree with Heikki that this overhead would
be unnoticeable. (Of course, some investigation proving that
wouldn't be unwarranted.)
regards, tom lane
Note, for this above feature, I was thinking we have a ROW_COUNT variable I use \set to see.
The simplest way to add this is maybe a set variable: EXEC_TIME
And it's set when ROW_COUNT gets set.
+1
==
Now, since this opened a lively discussion, I am officially submitting my first patch.
This includes the small change to prompt.c and the documentation. I had help from Andrey Borodin,
and Pavel Stehule, who have supported me in how to propose, and use gitlab, etc.
We are programmers... It's literally our job to sharpen our tools. And PSQL is one of my most used.
A small frustration, felt regularly was the motive.
Regards, Kirk
PS: If I am supposed to edit the subject to say there is a patch here, I did not know
PPS: I appreciate ANY and ALL feedback... This is how we learn!
