Re: Discussion: psql \et -> edit the trigger function - Mailing list pgsql-hackers

From Kirk Wolak
Subject Re: Discussion: psql \et -> edit the trigger function
Date
Msg-id CACLU5mQ1q_qDd3wtvFtOVvjySjL5Xin+u_Zawz75RW=D_NVt-A@mail.gmail.com
Whole thread Raw
In response to Re: Discussion: psql \et -> edit the trigger function  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: Discussion: psql \et -> edit the trigger function
Re: Discussion: psql \et -> edit the trigger function
List pgsql-hackers
On Wed, May 10, 2023 at 12:20 PM Pavel Stehule <pavel.stehule@gmail.com> wrote:
Hi

st 10. 5. 2023 v 17:33 odesílatel Kirk Wolak <wolakk@gmail.com> napsal:
We already have
\ef
\ev

The use case here is simply that it saves me from:
\d <table>
[scroll through all the fields]
[often scroll right]
select function name
\ef [paste function name]

and tab completion is much narrower

When doing conversions and reviews all of this stuff has to be reviewed.
Oftentimes, renamed, touched.

I am 100% willing to write the code, docs, etc. but would appreciate feedback.

\et can be little bit confusing, because looks like editing trigger, not trigger function

what \eft triggername

?

Pavel, I am "torn" because of my OCD, I would expect 
\eft <TAB>
to list functions that RETURN TRIGGER as opposed to the level of indirection I was aiming for.

where
\et <TAB>
  Would specifically let me complete the Trigger_Name, but find the function

It makes me wonder, now if:
\etf 

Is better for this (edit trigger function... given the trigger name).
And as another poster suggested.  As we do the AUTOCOMPLETE for that, we could address it for:
\ef?

because:
\eft <TAB>
is valuable as well, and deserves to work just like all \ef? items

It seems like a logical way to break it down.   
regards

Pavel

 

Kirk...

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Use RelationClose rather than table_close in heap_create_with_catalog
Next
From: Bharath Rupireddy
Date:
Subject: Re: WAL Insertion Lock Improvements