Re: minor error message inconsistency in make_pathkey_from_sortinfo - Mailing list pgsql-hackers

From jian he
Subject Re: minor error message inconsistency in make_pathkey_from_sortinfo
Date
Msg-id CACJufxGc3Ewc1MKm6qRpYe=kfHK_zbZ2OWVUsopbQSOHkpTgQA@mail.gmail.com
Whole thread Raw
In response to Re: minor error message inconsistency in make_pathkey_from_sortinfo  (Yugo NAGATA <nagata@sraoss.co.jp>)
Responses Re: minor error message inconsistency in make_pathkey_from_sortinfo
List pgsql-hackers
On Wed, Apr 24, 2024 at 5:47 PM Yugo NAGATA <nagata@sraoss.co.jp> wrote:
>
> On Wed, 24 Apr 2024 15:05:00 +0800
> jian he <jian.universality@gmail.com> wrote:
>
> > hi.
> >
> > in make_pathkey_from_sortinfo
> >
> > equality_op = get_opfamily_member(opfamily,
> >   opcintype,
> >   opcintype,
> >   BTEqualStrategyNumber);
> > if (!OidIsValid(equality_op)) /* shouldn't happen */
> > elog(ERROR, "missing operator %d(%u,%u) in opfamily %u",
> > BTEqualStrategyNumber, opcintype, opcintype, opfamily);
> >
> > the error message seems not right?
>
> This message was introduced by 278cb434110 which was aiming to
> standardize the wording for similar errors. We can find the pattern
>
>  "missing {support function | operator} %d(%u,%u) in opfamily %u"
>
> in several places.
>

the error message
` operator %d`
would translate to
` operator 3`

but there is oid as 3 operator in the catalog.
that's my confusion.
the discussion at [1] didn't explain my confusion.


[1] https://postgr.es/m/CAGPqQf2R9Nk8htpv0FFi+FP776EwMyGuORpc9zYkZKC8sFQE3g@mail.gmail.com



pgsql-hackers by date:

Previous
From: Dagfinn Ilmari Mannsåker
Date:
Subject: Re: Doc anchors for COPY formats
Next
From: Andres Freund
Date:
Subject: Re: pgsql: meson: Add initial version of meson based build system