minor error message inconsistency in make_pathkey_from_sortinfo - Mailing list pgsql-hackers

From jian he
Subject minor error message inconsistency in make_pathkey_from_sortinfo
Date
Msg-id CACJufxGNJqR79WEwBRw9g2DB-6WhNcJs1uuG7KnTGA5ouM6eug@mail.gmail.com
Whole thread Raw
Responses Re: minor error message inconsistency in make_pathkey_from_sortinfo
List pgsql-hackers
hi.

in make_pathkey_from_sortinfo

equality_op = get_opfamily_member(opfamily,
  opcintype,
  opcintype,
  BTEqualStrategyNumber);
if (!OidIsValid(equality_op)) /* shouldn't happen */
elog(ERROR, "missing operator %d(%u,%u) in opfamily %u",
BTEqualStrategyNumber, opcintype, opcintype, opfamily);

the error message seems not right?

maybe
if (!OidIsValid(equality_op)) /* shouldn't happen */
elog(ERROR, "missing operator =(%u,%u) in opfamily %u",opcintype,
opcintype, opfamily);

or

if (!OidIsValid(equality_op)) /* shouldn't happen */
elog(ERROR, "missing equality operator for type %u in opfamily
%u",opcintype, opcintype, opfamily);



pgsql-hackers by date:

Previous
From: Jakub Wartak
Date:
Subject: Re: GUC-ify walsender MAX_SEND_SIZE constant
Next
From: Michael Paquier
Date:
Subject: Partitioned tables and [un]loggedness