Re: bug: virtual generated column can be partition key - Mailing list pgsql-hackers

From jian he
Subject Re: bug: virtual generated column can be partition key
Date
Msg-id CACJufxGK=KkZS3sPA65CL4_p_KNvJ-fSb4v8Zd=WCWe5MfybxA@mail.gmail.com
Whole thread Raw
In response to Re: bug: virtual generated column can be partition key  (jian he <jian.universality@gmail.com>)
Responses Re: bug: virtual generated column can be partition key
List pgsql-hackers
On Tue, Apr 22, 2025 at 3:02 PM jian he <jian.universality@gmail.com> wrote:
> Other than that, it looks good to me for fixing this bug.

The error message seems not that intuitive.

+CREATE TABLE gtest_part_key (f1 date NOT NULL, f2 bigint, f3 bigint
GENERATED ALWAYS AS (f2 * 2) VIRTUAL) PARTITION BY RANGE
((gtest_part_key));
+ERROR:  cannot use generated column in partition key
+LINE 1: ...D ALWAYS AS (f2 * 2) VIRTUAL) PARTITION BY RANGE ((gtest_par...
+                                                             ^
+DETAIL:  Column "f3" is a generated column.

with the attached patch. now,
+CREATE TABLE gtest_part_key (f1 date NOT NULL, f2 bigint, f3 bigint
GENERATED ALWAYS AS (f2 * 2) VIRTUAL) PARTITION BY RANGE
((gtest_part_key));
ERROR:  cannot use generated column in partition key
LINE 1: ...D ALWAYS AS (f2 * 2) VIRTUAL) PARTITION BY RANGE ((gtest_par...
                                                             ^
DETAIL:  Generated column "f3" is part of the partition key of
relation "gtest_part_key"


what do you think?

Attachment

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: What's our minimum supported Python version?
Next
From: Ashutosh Bapat
Date:
Subject: Re: bug: virtual generated column can be partition key