Re: add function argument name to substring and substr - Mailing list pgsql-hackers

On Tue, Apr 1, 2025 at 6:22 AM David G. Johnston
<david.g.johnston@gmail.com> wrote:
>
> On Tue, Mar 18, 2025 at 9:04 PM jian he <jian.universality@gmail.com> wrote:
>>
>>
>> new patch attached.
>>
>
> I've done v4 with a delta patch.
>
> Decided to standardize on calling the SQL Similar To regular expression escape replaceable "escape" everywhere.
>
> Instead of fully documenting the obsolete syntax I added a note explaining the keyword choice difference.  Removed
mentionof it completely from the Pattern Matching portion of the documentation - that section has enough going on. 
>
> I also add "Same as" references for the two pairs of entries.  Not married to them but they do seem warranted; having
PatternMatching be required reading to make that connection seems undesirable. 
>

your v4-0001-v3-0001-substring.patch is not the same as my
v3-0001-add-argument-name-to-function-substring-and-subst.patch

for example:

-       <para role="func_signature">
+       <para role="func_signature"><s>
         <function>substring</function> (
<parameter>string</parameter> <type>text</type>
<literal>FROM</literal> <parameter>pattern</parameter>
<type>text</type> <literal>FOR</literal> <parameter>escape</parameter>
<type>text</type> )
-        <returnvalue>text</returnvalue>
+        <returnvalue>text</returnvalue></s>

can you make sure v4-0001-v3-0001-substring.patch the same as
v3-0001-add-argument-name-to-function-substring-and-subst.patch.

because I tried
git am


On Tue, Apr 1, 2025 at 6:22 AM David G. Johnston
<david.g.johnston@gmail.com> wrote:
>
> On Tue, Mar 18, 2025 at 9:04 PM jian he <jian.universality@gmail.com> wrote:
>>
>>
>> new patch attached.
>>
>
> I've done v4 with a delta patch.
>
> Decided to standardize on calling the SQL Similar To regular expression escape replaceable "escape" everywhere.
>
> Instead of fully documenting the obsolete syntax I added a note explaining the keyword choice difference.  Removed
mentionof it completely from the Pattern Matching portion of the documentation - that section has enough going on. 
>
> I also add "Same as" references for the two pairs of entries.  Not married to them but they do seem warranted; having
PatternMatching be required reading to make that connection seems undesirable. 
>

your v4-0001-v3-0001-substring.patch is not the same as my
v3-0001-add-argument-name-to-function-substring-and-subst.patch

for example:

-       <para role="func_signature">
+       <para role="func_signature"><s>
         <function>substring</function> (
<parameter>string</parameter> <type>text</type>
<literal>FROM</literal> <parameter>pattern</parameter>
<type>text</type> <literal>FOR</literal> <parameter>escape</parameter>
<type>text</type> )
-        <returnvalue>text</returnvalue>
+        <returnvalue>text</returnvalue></s>

can you make sure v4-0001-v3-0001-substring.patch the same as
v3-0001-add-argument-name-to-function-substring-and-subst.patch.

because I tried git am


On Tue, Apr 1, 2025 at 6:22 AM David G. Johnston
<david.g.johnston@gmail.com> wrote:
>
> On Tue, Mar 18, 2025 at 9:04 PM jian he <jian.universality@gmail.com> wrote:
>>
>>
>> new patch attached.
>>
>
> I've done v4 with a delta patch.
>
> Decided to standardize on calling the SQL Similar To regular expression escape replaceable "escape" everywhere.
>
> Instead of fully documenting the obsolete syntax I added a note explaining the keyword choice difference.  Removed
mentionof it completely from the Pattern Matching portion of the documentation - that section has enough going on. 
>
> I also add "Same as" references for the two pairs of entries.  Not married to them but they do seem warranted; having
PatternMatching be required reading to make that connection seems undesirable. 
>

can not build docs based on your v4-0001.

your v4-0001-v3-0001-substring.patch is not the same as my
v3-0001-add-argument-name-to-function-substring-and-subst.patch

for example:
-       <para role="func_signature">
+       <para role="func_signature"><s>
         <function>substring</function> (
<parameter>string</parameter> <type>text</type>
<literal>FROM</literal> <parameter>pattern</parameter>
<type>text</type> <literal>FOR</literal> <parameter>escape</parameter>
<type>text</type> )
-        <returnvalue>text</returnvalue>
+        <returnvalue>text</returnvalue></s>

because I tried
git am v3-0001-add-argument-name-to-function-substring-and-subst.patch.
patch -p1 < v4-0002-v3-0002-delta.patch
Then there are several places that differ, it doesn't seem easy to
resolve the difference.



Can you make sure v4-0001-v3-0001-substring.patch the same as
v3-0001-add-argument-name-to-function-substring-and-subst.patch,
then I can review your delta patch.