On Sun, Jan 8, 2023 at 4:22 AM Joseph Koshakow <koshy44@gmail.com> wrote:
On Sat, Jan 7, 2023 at 3:05 PM Joseph Koshakow <koshy44@gmail.com> wrote: > > On Sat, Jan 7, 2023 at 3:04 PM Joseph Koshakow <koshy44@gmail.com> wrote: > > > > I think this patch is just about ready for review, except for the > > following two questions: > > 1. Should finite checks on intervals only look at months or all three > > fields? > > 2. Should we make the error messages for adding/subtracting infinite > > values more generic or leave them as is? > > > > My opinions are > > 1. We should only look at months. > > 2. We should make the errors more generic. > > > > Anyone else have any thoughts?
Here's a patch with the more generic error messages.
- Joe
HI.
I just found out another problem.
select * from generate_series(timestamp'-infinity', timestamp 'infinity', interval 'infinity'); ERROR: timestamp out of range
select * from generate_series(timestamp'-infinity',timestamp 'infinity', interval '-infinity'); --return following
generate_series ----------------- (0 rows)
select * from generate_series(timestamp 'infinity',timestamp 'infinity', interval 'infinity'); --will run all the time.
select * from generate_series(timestamp 'infinity',timestamp 'infinity', interval '-infinity'); ERROR: timestamp out of range
select * from generate_series(timestamp'-infinity',timestamp'-infinity', interval 'infinity'); ERROR: timestamp out of range
select * from generate_series(timestamp'-infinity',timestamp'-infinity', interval '-infinity');
--will run all the time.
--
I recommend David Deutsch's <<The Beginning of Infinity>>
