ATExecColumnDefault comments - Mailing list pgsql-hackers

From jian he
Subject ATExecColumnDefault comments
Date
Msg-id CACJufxFmLZTzmOV83O2Dd0Buh=HNYtPUs6VAcUGLv+KCWSyqqg@mail.gmail.com
Whole thread Raw
List pgsql-hackers
hi.
one minor issue for ATExecColumnDefault comments.


/*
 * ALTER TABLE ALTER COLUMN SET/DROP DEFAULT
 *
 * Return the address of the affected column.
 */
static ObjectAddress
ATExecColumnDefault(Relation rel, const char *colName,
                    Node *newDefault, LOCKMODE lockmode)

the comment should be:
 * ALTER TABLE ALTER COLUMN SET/DROP DEFAULT
 * ALTER VIEW  ALTER COLUMN SET/DROP DEFAULT
?


Sometimes, comments are useful for quickly glance at what this function does.
Therefore I guess reword it would be helpful.



pgsql-hackers by date:

Previous
From: Paul A Jungwirth
Date:
Subject: Re: SQL:2011 application time
Next
From: Tom Lane
Date:
Subject: Re: updatable view set default interact with base rel generated stored columns