Re: Spinlock can be released twice in procsignal.c - Mailing list pgsql-hackers

From Maxim Orlov
Subject Re: Spinlock can be released twice in procsignal.c
Date
Msg-id CACG=ezbScO5O2CTZYy-Rqs-VHQ_f3aaRWL6VQZpyjC4uMVVDoA@mail.gmail.com
Whole thread Raw
In response to Re: Spinlock can be released twice in procsignal.c  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Spinlock can be released twice in procsignal.c
List pgsql-hackers

On Wed, 26 Feb 2025 at 07:56, Michael Paquier <michael@paquier.xyz> wrote:

This fix is not correct.  No system function calls (well basically
most of them) or even more no PostgreSQL-specific calls should happen
while holding a spinlock.  elog() is a good example of what not to do.
One example: imagine a palloc failure while holding this spinlock in
this elog().

Indeed. PFA the correct one.


--
Best regards,
Maxim Orlov.
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [BUG]: the walsender does not update its IO statistics until it exits
Next
From: ego alter
Date:
Subject: Re: support virtual generated column not null constraint