Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. - Mailing list pgsql-hackers

From Максим Орлов
Subject Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.
Date
Msg-id CACG=ezZYRH6u5a642_TC+LidT8UKACN+UU48B07ioJFnZ5aOtA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.  (Mark Dilger <mark.dilger@enterprisedb.com>)
Responses Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.  (Julien Rouhaud <rjuju123@gmail.com>)
List pgsql-hackers
Tree view
The pstrdup is unnecessary but harmless.

> - use the existing table for uniqueness check in 005_opclass_damage.pl

It appears you still create a new table, bttest_unique, rather than using the existing table int4tbl.  That's fine.

> - added tests into 003_check.pl . It is only smoke test that just verifies new functions.

You have borrowed the existing tests but forgot to change their names.  (The last line of each check is the test name, such as 'pg_amcheck smoke test --parent-check'.)  Please make each test name unique.

Thanks for your review! Fixed all these remaining things from patch v6.
PFA v7 patch.

---
Best regards,
Maxim Orlov.
Attachment

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Buildfarm support for older versions
Next
From: Tomas Vondra
Date:
Subject: Re: sequences vs. synchronous replication