Postgres Pro
Downloads
Home   >   mailing lists

[pgAdmin4][runtime][patch]: Fix for RM#2679 - Mailing list pgadmin-hackers

From Neel Patel
Subject [pgAdmin4][runtime][patch]: Fix for RM#2679
Date
Msg-id CACCA4P1oZWXwdwxooxDM7V+W8Y9fXdPMYoYVJubFxSoiLcO0Dg@mail.gmail.com
Whole thread Raw
Responses Re: [pgAdmin4][runtime][patch]: Fix for RM#2679  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
Hi,

Please find attached patch to fix RM#2679.

Issue:-
Getting started links does not open second time from "Dashboard" panel if User close runtime tab and open any URL again.

Analysis:-
As in runtime Qt application, when user defined "target=_new" then "createWindow" signal is called but when user close that new windows and again click on link then "createWindow" signal is not getting called so from user point view nothing will happen.

Solution:-
To make it work in both runtime and web application, changed "target" attribute to "_blank" so that "createWindow" signal will be called every time when user click on any link.

Do review it and let me know for comments.

Thanks,
Neel Patel



Attachment

pgadmin-hackers by date:

Previous
From: Neel Patel
Date:
Subject: Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crasheswhile saving CSV data from Query tool
Next
From: Dave Page
Date:
Subject: Re: [pgAdmin4][Patch]: Allow user to choose background colour for server