Please find the attached patch to fix the issue in Windows as I mentioned earlier. Please work on top of this to fix the issue below.
I can see the issue below in desktop mode. Here home directory is "C:\Users\neel" but on dialog it shows "C:\" which is wrong.
When we press the "Home" button, it redirects to "C:\Users\neel" which is correct but again when we press the "back" button, it shows the path "C:\" which is wrong.
So when the user is in the home directory path and presses the "Back" button it should remain on the same path. This is not specific to windows but it should also reproducible in linux as well.
Can you please verify and fix ?
By "Back", do you mean "Parent Directory" (i.e. the button next to the Home button)? If so, shouldn't that take you to C:\Users?
Yes, the button next to the Home button. Here in Desktop mode, the user will be currently logged in OS user right ? Do we need to show all the users info ? I think we should show the home directory of currently logged in OS user ( e.g. C:\Users\neel ), Isn't it ?
I have tested this patch in linux (Ubuntu 18.04) env only , which is working fine. It will be great if someone can review/test in the Windows environment as well as I don't have the setup ready for that.
Just did an eyeball review. You've included homedir path in the response rendered JS file. You're exposing underlying directory structure to users even in server mode. This is not appropriate. This info should remain at the server and not at the client side.