Postgres Pro
Downloads
Home   >   mailing lists

[Patch][pgAdmin4][runtime]: RM#1375 - Migrate the runtime to QtWebEngine from QtWebKit - Mailing list pgadmin-hackers

From Neel Patel
Subject [Patch][pgAdmin4][runtime]: RM#1375 - Migrate the runtime to QtWebEngine from QtWebKit
Date
Msg-id CACCA4P18f7=57mrr3bgfYwGavdUkNfVDTem5AvQHum--sLpznw@mail.gmail.com
Whole thread Raw
Responses Re: [Patch][pgAdmin4][runtime]: RM#1375 - Migrate the runtime to QtWebEngine from QtWebKit  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
Hi,

Please find attached initial patch for migration of runtime to QtWebEngine from QtWebkit.

Observation:-

When user click on already opened link, it will not set existing tab index but always open in new tab.
e.g. pgAdmin4 website is already open in new tab and user again open the same website then it will not set existing tab index but always open in new tab.

First "createWindow" virtual protected method is getting called which does not contain any URL of page but it will create WebEnginePage for the WebEngineView.
Once the WebEnginePage is created in above method, we are getting "acceptNavigationRequested" call which contains URL so before we save the URL, tab was already opened so we are not able to compare with existing opened tab.

I have tested this patch on Linux & Mac and it is working as expected.

Do review it and let us know for any comments.

Thanks,
Neel Patel
Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: [pgAdmin4][Patch]: RM 1919 View Filtered Rows only saving a single change per row
Next
From: Murtuza Zabuawala
Date:
Subject: PATCH: arguments of Trigger function was not displaying properly (pgAdmin4)