Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin3][Extension]: Wrong SQL generated - Mailing list pgadmin-hackers

From Neel Patel
Subject Re: [pgAdmin3][Extension]: Wrong SQL generated
Date
Msg-id CACCA4P0dr2MoPHRX_Px3UroVBd3UJ8m2VEC2DGmCy1wogDQjTw@mail.gmail.com
Whole thread Raw
In response to [pgAdmin3][Extension]: Wrong SQL generated  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi,

Please find attached patch file for the issue mentioned below.

Issue:- 
When user "Edit" any existing extension module property, and try to change the schema and version field to blank then SQL should not be generated for the blank field.

Above issue is fixed with attached patch file.

Do review it and let us know for any comments.

Thanks,
Neel Patel

On Mon, Jan 18, 2016 at 4:33 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi all,


While implementing Extension module in pgAdmin4, I came to know that there is an bug in pgadmin3.

Following are the steps to reproduce it:
1. Edit an existing extension.
2. In definition tab, set schema and version fields to empty.
3. In SQL tab, it generates an sql for the changes made which is wrong, it shouldn't generate sql for the schema and version field if it is kept empty, both fields should be validated.


Below is the wrong SQL generated:

ALTER EXTENSION btree_gin
  SET SCHEMA ;
ALTER EXTENSION btree_gin
  UPDATE TO ;


Let me know for any comments.

Thanks
Surinder Kumar

Attachment

pgadmin-hackers by date:

Previous
From: Neel Patel
Date:
Subject: Re: Observed bug in pgAdmin3
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Further nice-ification of the runtime UI.