Re: [pgAdmin4]: Fix for RM #3248 - Mailing list pgadmin-hackers

From Neel Patel
Subject Re: [pgAdmin4]: Fix for RM #3248
Date
Msg-id CACCA4P01Sf7cq6xnTZCfRcdG0QEBp0PFPKhPtqbOqg2Od04DrA@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4]: Fix for RM #3248  (Neel Patel <neel.patel@enterprisedb.com>)
Responses Re: [pgAdmin4]: Fix for RM #3248
List pgadmin-hackers
Hi,

Please find updated patch after fixing the comments.
Review it and let me know for comments.

Thanks,
Neel Patel

On Thu, Apr 5, 2018 at 11:32 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Thanks Murtuza & Khushboo.
I will send updated patch.

Thanks,
Neel Patel

On Thu, Apr 5, 2018 at 11:29 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Neel,

Add below code to the top (around line no 8) in alertify.pgadmin.defaults.js file will solve the problem.

alertify.defaults.closable = false;


Thanks,
Khushboo

On Thu, Apr 5, 2018 at 11:13 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Neel,

Can we make the change in wrapper instead of changing every where?
File: ../web/pgadmin/static/js/alertify.pgadmin.defaults.js


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Apr 5, 2018 at 11:04 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi,

Please find attached patch for the fix of RM #3248 - we have modified alertify confirm dialog to modal dialog.

Do review it and let me know for comments.

Thanks,
Neel Patel




Attachment

pgadmin-hackers by date:

Previous
From: Neel Patel
Date:
Subject: Re: [pgAdmin4]: Fix for RM #3248
Next
From: Neel Patel
Date:
Subject: Re: pgAdmin 4 commit: Fix a number of broken connection detection scenarios