Postgres Pro
Downloads
Home   >   mailing lists

Re: Re: pglogical_output - a general purpose logical decoding output plugin - Mailing list pgsql-hackers

From Shulgin, Oleksandr
Subject Re: Re: pglogical_output - a general purpose logical decoding output plugin
Date
Msg-id CACACo5Q2GBjzVW4H4hjDRny2-yKzJx-sVT-+gtHaOcK2TV3z0g@mail.gmail.com
Whole thread Raw
In response to Re: pglogical_output - a general purpose logical decoding output plugin  (Tomasz Rybak <tomasz.rybak@post.pl>)
Responses Re: Re: pglogical_output - a general purpose logical decoding output plugin
List pgsql-hackers
Tree view
On Sun, Jan 3, 2016 at 7:21 PM, Tomasz Rybak <tomasz.rybak@post.pl> wrote:
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       not tested
Spec compliant:           not tested
Documentation:            tested, failed

Applies cleanly on current master (b416c0bb622ce5d33fdbec3bbce00451132f10ec).

Builds without any problems on current Debian unstable (am64 arch, GCC 5.3.1-4, glibc 2.21-6)

A make from an external build dir fails on install, suggested fix:

install: all
$(MKDIR_P) '$(DESTDIR)$(includedir)'/pglogical_output
- $(INSTALL_DATA) pglogical_output/hooks.h '$(DESTDIR)$(includedir)'/pglogical_output
+ $(INSTALL_DATA) $(top_srcdir)/contrib/pglogical_output/pglogical_output/hooks.h '$(DESTDIR)$(includedir)'/pglogical_output

--
Alex

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: custom function for converting human readable sizes to bytes
Next
From: Pavel Stehule
Date:
Subject: Re: custom function for converting human readable sizes to bytes