Re: Atomic rename feature for Windows. - Mailing list pgsql-hackers

From Juan José Santamaría Flecha
Subject Re: Atomic rename feature for Windows.
Date
Msg-id CAC+AXB3x=G=uK-ihBvws9JQzyOJRps8g-2QOcE5ZosBLzOLgNg@mail.gmail.com
Whole thread Raw
In response to Re: Atomic rename feature for Windows.  (Victor Spirin <v.spirin@postgrespro.ru>)
Responses Re: Atomic rename feature for Windows.  (Victor Spirin <v.spirin@postgrespro.ru>)
List pgsql-hackers

On Tue, Sep 7, 2021 at 11:40 PM Victor Spirin <v.spirin@postgrespro.ru> wrote:

I checked the pgrename_windows_posix_semantics() function on Windows 7.
It returns error 87: Parameter is incorrect. Hence, it is necessary to
check the Windows version and call the old pgrename function for old
Windows.

The FILE_RENAME_FLAGs are available starting from Windows 10 Release id 1607, NTDDI_WIN10_RS1. The check should be using something like IsWindowsVersionOrGreater(10, 0, 1607). Or you could test this using RtlGetVersion(), loading it from ntdll infrastructure coming from stat() patch [1], which doesn't need a manifest.


Regards,

Juan José Santamaría Flecha

pgsql-hackers by date:

Previous
From: Ranier Vilela
Date:
Subject: Re: Eval expression R/O once time (src/backend/executor/execExpr.c)
Next
From: Thomas Munro
Date:
Subject: Re: Atomic rename feature for Windows.