On 2020-Sep-04, Juan José Santamaría Flecha wrote:
> On Fri, Sep 4, 2020 at 9:37 PM Alvaro Herrera <alvherre@2ndquadrant.com> > wrote: > > > On 2020-Sep-04, Thomas Munro wrote:
> > > > > > +/* File types for 'd_type'. */ > > > +enum > > > + { > > > + DT_UNKNOWN = 0, > > > +# define DT_UNKNOWN DT_UNKNOWN > > > > Uhm ... what do these #defines do? They look a bit funny. > > > > Would it make sense to give this enum a name, and then use that name in > > struct dirent's definition, instead of unsigned char? > > They mimic POSIX dirent.h. I would rather stick to that.
Ah ... they do?
If you remove the #define lines, what happens to your patch?
If will fail to detect that the patch makes the optimisation available for WIN32:
