On Tue, Nov 15, 2022 at 9:02 PM Andres Freund <andres@anarazel.de> wrote:
On 2022-11-15 15:35:31 +0100, Juan José Santamaría Flecha wrote: > On Tue, Nov 15, 2022 at 1:49 AM Andres Freund <andres@anarazel.de> wrote: > > Hm. Is it right that the changes are only done for msvc? win32_port.h > > defines the types for mingw as well afaict.
> Yes, it does, but configure does nothing with them, so adding those > defines is a new feature for MinGW but a correction for MSVC.
Any chance you checked if autoconf already detects locale_t with mingw? Possible that mingw supplies one of the relevant headers...
Otherwise it looks like a sensible improvement to me.
I've checked the autoconf version of pg_config.h and it's not detected. Also, manually inspecting <locale.h> I see no definition of locale_t in MinGW.
