Re: Can we get rid of GetLocaleInfoEx() yet? - Mailing list pgsql-hackers

From Juan José Santamaría Flecha
Subject Re: Can we get rid of GetLocaleInfoEx() yet?
Date
Msg-id CAC+AXB2xJiYDHDZX01DNchQ0nu4XcQcOX7MHPdAijEaJVhG8DA@mail.gmail.com
Whole thread Raw
In response to Can we get rid of GetLocaleInfoEx() yet?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Can we get rid of GetLocaleInfoEx() yet?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

On Sun, Mar 29, 2020 at 3:29 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:

The reason for the hack, per the comments, is that VS2015
omits a codepage field from the result of _create_locale();
and some optimism is expressed therein that Microsoft might
undo that oversight in future.  Has this been fixed in more
recent VS versions?  If not, can we find another, more robust
way to do it?

While working on another issue I have seen this issue reproduce in VS2019. So no, it has not been fixed.

Please find attached a patch that provides a better detection of the "uft8" cases.

Regards,

Juan José Santamaría Flecha

Attachment

pgsql-hackers by date:

Previous
From: Julien Rouhaud
Date:
Subject: Re: pg_stat_statements issue with parallel maintenance (Was Re: WALusage calculation patch)
Next
From: Dean Rasheed
Date:
Subject: Re: PATCH: add support for IN and @> in functional-dependencystatistics use