Re: Windows port minor fixes - Mailing list pgsql-hackers

From Juan José Santamaría Flecha
Subject Re: Windows port minor fixes
Date
Msg-id CAC+AXB2u8YYghvwRN2gNOx+gO2_6uNc+2D2KOJbYBLZqLJsuOw@mail.gmail.com
Whole thread Raw
In response to Windows port minor fixes  (Ranier Vilela <ranier_gyn@hotmail.com>)
Responses Re: Windows port minor fixes  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers


On Mon, Dec 16, 2019 at 6:34 PM Ranier Vilela <ranier_gyn@hotmail.com> wrote:

Considering that postgres only supports windows versions that have the new API, it would be good to make the replace.


That is not actually the case. If you check the _WIN32_WINNT logic in src/include/port/win32.h you can see that depending on your building tools you can get a version lower than that, for example if using MinGW.
 

* memory leak fix to src/common/exec.c
* CryptGenRandom change by BCryptGenRandom to src/port/pg_strong_random.c
* link bcrypt.lib to src/tools/msvc/Mkvcbuild.pm


If you want to address 2 unrelated issues, it makes little sense to use a single thread and 3 patches.

Regards,

Juan José Santamaría Flecha  

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: polymorphic table functions light
Next
From: Pavel Stehule
Date:
Subject: Re: polymorphic table functions light