Postgres Pro
Downloads
Home   >   mailing lists

Re: Fix vcregress plpython3 warning - Mailing list pgsql-hackers

From Juan José Santamaría Flecha
Subject Re: Fix vcregress plpython3 warning
Date
Msg-id CAC+AXB1mW4QDy0E+HqYkxp3YitiJp_Lc8zKDxDCJ0kTrgUS9ug@mail.gmail.com
Whole thread Raw
In response to Re: Fix vcregress plpython3 warning  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: Fix vcregress plpython3 warning
Re: Fix vcregress plpython3 warning
List pgsql-hackers
Tree view

On Fri, Jan 7, 2022 at 2:30 PM Andrew Dunstan <andrew@dunslane.net> wrote:

Yeah, this code is not a model of clarity though. I had to think through
it and I write quite a bit of perl. I would probably write it something
like this:


s/EXTENSION (.*?)plpython2?u/EXTENSION $1plpython3u/g ;

Yeah, I had to do some testing to figure it out. Based on what regress-python3-mangle.mk does, I think it tries to ignore cases such as:

DROP EXTENSION IF EXISTS plpython2u CASCADE;

Which that expression would match. Maybe use a couple of lines as in the make file?

s/EXTENSION plpython2?u/EXTENSION plpython3u/g
s/EXTENSION ([^ ]*)_plpython2?u/EXTENSION \$1_plpython3u/g

Regards,

Juan José Santamaría Flecha

pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file
Next
From: Juan José Santamaría Flecha
Date:
Subject: Re: Fix vcregress plpython3 warning